Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
fix(warns): modify maybeComponent function in parser (#10167)
fixes #10152
  • Loading branch information
zrh122 committed Apr 7, 2021
1 parent 5c459f0 commit 0603ff6
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 2 deletions.
8 changes: 6 additions & 2 deletions src/compiler/parser/index.js
Expand Up @@ -86,8 +86,12 @@ export function parse (
platformMustUseProp = options.mustUseProp || no
platformGetTagNamespace = options.getTagNamespace || no
const isReservedTag = options.isReservedTag || no
maybeComponent = (el: ASTElement) => !!el.component || !isReservedTag(el.tag)

maybeComponent = (el: ASTElement) => !!(
el.component ||
el.attrsMap[':is'] ||
el.attrsMap['v-bind:is'] ||
!(el.attrsMap.is ? isReservedTag(el.attrsMap.is) : isReservedTag(el.tag))
)
transforms = pluckModuleFunction(options.modules, 'transformNode')
preTransforms = pluckModuleFunction(options.modules, 'preTransformNode')
postTransforms = pluckModuleFunction(options.modules, 'postTransformNode')
Expand Down
16 changes: 16 additions & 0 deletions test/unit/modules/compiler/parser.spec.js
Expand Up @@ -909,4 +909,20 @@ describe('parser', () => {
expect(ast.children[2].type).toBe(3)
expect(ast.children[2].text).toBe('\ndef')
})

// #10152
it('not warn when scoped slot used inside of dynamic component on regular element', () => {
parse(`
<div>
<div is="customComp" v-slot="slotProps"></div>
<div :is="'customComp'" v-slot="slotProps"></div>
<div v-bind:is="'customComp'" v-slot="slotProps"></div>
</div>
`, baseOptions)
expect('v-slot can only be used on components or <template>').not.toHaveBeenWarned()

parse(`<div is="customComp"><template v-slot="slotProps"></template></div>`, baseOptions)
expect(`<template v-slot> can only appear at the root level inside the receiving the component`)
.not.toHaveBeenWarned()
})
})

0 comments on commit 0603ff6

Please sign in to comment.