Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attributes listed under isBooleanAttr are altered under v-pre attributed tags #10087

Closed
xmakina opened this issue May 30, 2019 · 0 comments · Fixed by #10088
Closed

Attributes listed under isBooleanAttr are altered under v-pre attributed tags #10087

xmakina opened this issue May 30, 2019 · 0 comments · Fixed by #10088

Comments

@xmakina
Copy link
Contributor

xmakina commented May 30, 2019

Version

2.6.10

Reproduction link

https://jsfiddle.net/fp1omdaw/1/

Steps to reproduce

In a v-pre tag or child, use an attribute listed under the isBooleanAttr list in src\platforms\web\util\attrs.js

What is expected?

The attribute value is unchanged

What is actually happening?

The attribute value is changed, e.g. open has the value to set to open


When working with MathML, we need to use the open attribute

xmakina added a commit to xmakina/vue that referenced this issue May 30, 2019
posva added a commit that referenced this issue Sep 21, 2020
* fix(v-pre): do not alter attributes

close #10087

* fix(v-pre): do not alter attributes

remove component and replace option from unit test

* refactor: use or

* perf: check boolean before index

Co-authored-by: Eduardo San Martin Morote <posva@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants