Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(warns): avoid warning native modifiers on dynamic components #11052

Merged

Conversation

jedrula
Copy link
Contributor

@jedrula jedrula commented Jan 27, 2020

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Removes confusing warning

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Fix #10939

@posva posva changed the title Do not warn when binding native modifier on dynamic components, fixes#10939 Do not warn when binding native modifier on dynamic components, fixes #10939 Jan 27, 2020
jedrula referenced this pull request in base-angewandte/base-ui-components Jan 27, 2020
@posva posva changed the title Do not warn when binding native modifier on dynamic components, fixes #10939 Do not warn when binding native modifier on dynamic components Feb 24, 2021
@posva posva changed the title Do not warn when binding native modifier on dynamic components feat(warns): avoid warning native modifiers on dynamic components Feb 24, 2021
@posva posva added this to In Review in 2.6.13 Mar 5, 2021
@posva posva moved this from In Review to Reviewed once, needs another review in 2.6.13 Mar 9, 2021
@posva posva merged commit 3d46692 into vuejs:dev Mar 30, 2021
@posva posva moved this from Reviewed once, needs another review to Done in 2.6.13 Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Binding of events on dynamic components produce warnings
4 participants