Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr): inheritAttrs false adds attributes to html #11706

Merged
merged 2 commits into from Mar 30, 2021
Merged

Conversation

noreff
Copy link
Contributor

@noreff noreff commented Oct 5, 2020

Fix 11297.

After this fix inheritAttrs option works in a correct way and don't add attributes to html output.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@noreff noreff changed the title fix(ssr): inheritAttrs false adds attributes to html fix(ssr): inheritAttrs false adds attributes to html (fix #11297) Oct 5, 2020
@noreff
Copy link
Contributor Author

noreff commented Oct 5, 2020

Not sure what is the reason behind ci/circleci: test-cover shows me 1 broken test in completely unrelated area. Locally I have 0 errors after running npm run test

@noreff
Copy link
Contributor Author

noreff commented Oct 6, 2020

I made a little research about ci/circleci: test-cover failing, while local tests was passing. I found out that it did already happen before with a same test that is now failing for me. @posva wrote back than that it could be indeed failing because of a random thing and I have a filling that it does. I think that should be investigated further and be fixed. I can work on it, but I would be glad if some one verified first that it's needed.

Copy link

@vhoyer vhoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@posva posva changed the title fix(ssr): inheritAttrs false adds attributes to html (fix #11297) fix(ssr): inheritAttrs false adds attributes to html Mar 24, 2021
@posva posva added this to Reviewed once, needs another review in 2.6.13 Mar 24, 2021
@posva posva merged commit 7e5dc6b into vuejs:dev Mar 30, 2021
@posva posva moved this from Reviewed once, needs another review to Done in 2.6.13 Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

vue-server-renderer: inheritAttrs false doesn't work properly
3 participants