Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v-slot): fix scoped slot normalization combined with v-if #12104

Merged
merged 2 commits into from Jun 2, 2021

Conversation

posva
Copy link
Member

@posva posva commented Jun 2, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
Fixes #12102
Closes #12103

Copy link

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, even though my concerns regarding the vnode variable remain (res.length == 0 vs res.length === 1 seems more intuitive to me).

@posva posva merged commit 38f71de into dev Jun 2, 2021
@posva posva deleted the fix/12102-scoped-slot-normalization branch June 2, 2021 12:44
@caugner
Copy link

caugner commented Jun 3, 2021

@posva Thanks for the fix. Two questions:

  1. Shouldn't this PR be added to the 2.6.14 project?
  2. Should we expect a 2.6.14 release these days or rather in weeks?

@posva
Copy link
Member Author

posva commented Jun 3, 2021

A new release in days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2.6.13] Node after v-if node inside named slot is not shown anymore
2 participants