Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$refs can also contain CreateComponentPublicInstance #12659

Merged
merged 2 commits into from Jul 15, 2022

Conversation

NikhilVerma
Copy link
Contributor

@NikhilVerma NikhilVerma commented Jul 14, 2022

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

$refs in Vue's previous instance can also contain references to the new defineComponent style components. This fixes an issue where if you are referencing a defineComponent component inside a vue-class-component it throws errors about mismatching $refs type

@NikhilVerma
Copy link
Contributor Author

@yyx990803 This fixes an error where $refs can't be typed properly when using the new defineComponent created components

@yyx990803 yyx990803 merged commit fffbb9e into vuejs:main Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants