Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(src/server/render.js): fixes component directives rendering (fix #10733) #12661

Merged
merged 1 commit into from Aug 18, 2022

Conversation

manniL
Copy link
Contributor

@manniL manniL commented Jul 14, 2022

This is a follow-up of #11287 which resolves #10733.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch for v2.x (or to a previous version branch), not the master branch - No because dev seems to be outdated.
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • All tests are passing: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#development-setup
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Co-authored-by: Bruno Trecenti <bruno.lopestrecenti@gmail.com>
@yyx990803 yyx990803 merged commit 165a14a into vuejs:main Aug 18, 2022
@manniL manniL deleted the fix/directive-ssr-component branch August 22, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vue-server-renderer: directive not applied to imported component
2 participants