Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #12666: vue.d.ts: Relativise to v3-component-public-instance #12668

Merged
merged 2 commits into from Jul 16, 2022

Conversation

sandersn
Copy link
Contributor

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

Other information:

I didn't investigate why vue's tsconfig incorrectly resolves an absolute reference to v3-component-public-instance, so I was unable to start with a failing test.

@sandersn
Copy link
Contributor Author

sandersn commented Jul 15, 2022

The setting that allows types/tsconfig.json to resolve absolute references by mistake is baseUrl: ".". I removed it, because I don't think it makes sense here.

@yyx990803 yyx990803 merged commit 46ec648 into vuejs:main Jul 16, 2022
@sandersn sandersn deleted the fix-vue.d.ts-2.7.6 branch July 18, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants