fix: allow full hostnames in asset url base, fix #12731 #12732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
jonaskuske
added a commit
to jonaskuske/kirbyup
that referenced
this pull request
Aug 9, 2022
jonaskuske
added a commit
to jonaskuske/kirbyup
that referenced
this pull request
Aug 13, 2022
johannschopplich
pushed a commit
to johannschopplich/kirbyup
that referenced
this pull request
Aug 15, 2022
* feat: add support for `kirby serve` w/ HMR plugin * feat: allow HMR refresh, abort only on HMR reload * feat: rename module entry to _index.mjs makes it clearer that module entries are an internal, dev-only feature * docs: update examples to include serve script * feat: reload on PHP change in serve mode * feat: live-reload via CLI arg, CLI help, refactor * fix: only call server.close() if still listening * fix: set server.origin to serve assets in dev mode depends on vuejs/vue#12732 * fix: always pass array to vite-full-reload-plugin ElMassimo/vite-plugin-full-reload#9 * feat: specify port via cli instead of kirbyup conf * refactor: update reload-plugin, remove workaround * feat: make sure index.dev.mjs is gone after build * feat: set index.dev.mjs location with --out-dir * docs: update README for serve command * docs: capitalize "panel" * refactor: inline getViteConfig() type * fix: only handle SIGINT, implemented like vite
johannschopplich
added a commit
to johannschopplich/kirbyup
that referenced
this pull request
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #12731
modeled after https://github.com/vuejs/core/blob/a95554d35c65e5bfd0bf9d1c5b908ae789345a6d/packages/compiler-sfc/src/templateTransformAssetUrl.ts#L120-L130
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: