Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr): renderToString cannot render comment #9128

Merged
merged 3 commits into from Dec 12, 2018

Conversation

clarkdo
Copy link
Contributor

@clarkdo clarkdo commented Nov 30, 2018

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
Fix nuxt/nuxt#4458

@posva
Copy link
Member

posva commented Nov 30, 2018

Don't forget the test case 😄

@clarkdo
Copy link
Contributor Author

clarkdo commented Nov 30, 2018

@posva renderToString is using normalizeRender to create the compiler, but it doesn't pass comments parameter, so comments won't be renderered even after my pr.

But this pr can fix the scenario that component is loaded from vue-loader which is using comments attr to set the comments parameter.

@yyx990803
Copy link
Member

We could have a test case that manually compiles the template with explicit comments options. A bit tedious but I think a test case is still needed.

@clarkdo
Copy link
Contributor Author

clarkdo commented Dec 1, 2018

Make sense, I’ll add one.

@clarkdo
Copy link
Contributor Author

clarkdo commented Dec 12, 2018

@yyx990803 @posva Test added.

@yyx990803 yyx990803 merged commit b06c784 into vuejs:dev Dec 12, 2018
@manniL
Copy link
Contributor

manniL commented Jan 5, 2019

Couldn't this lead to mismatch errors when comments are stripped on client-side? 🤔

f2009 pushed a commit to f2009/vue that referenced this pull request Jan 25, 2019
aJean pushed a commit to aJean/vue that referenced this pull request Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nuxt generate comment handling
4 participants