Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(warn): better message with no constructors props #9241

Merged
merged 2 commits into from Mar 30, 2021
Merged

Conversation

Zarad1993
Copy link
Contributor

@Zarad1993 Zarad1993 commented Dec 22, 2018

Closes #9224

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe: Error Handling

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Proof

Before

screen shot 2018-12-22 at 1 36 46 pm

After

screen shot 2018-12-22 at 1 37 43 pm

@Zarad1993
Copy link
Contributor Author

@posva - Do you think this needs any changes or do you think it might be promoted to code review?

@Zarad1993
Copy link
Contributor Author

@posva - Just following up on this. A friendly reminder to have a peak at it when possible 😄

Copy link
Contributor

@sid-maddy sid-maddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor changes. @posva, please have a look at it as well.

src/core/util/props.js Outdated Show resolved Hide resolved
src/core/util/props.js Show resolved Hide resolved
@posva posva added this to Planned in 2.6.13 Mar 9, 2021
@posva posva changed the title Fix #9224 Warn type when not a constructor feat(warn): better message with no constructors props Mar 30, 2021
@posva posva moved this from Planned to In Review in 2.6.13 Mar 30, 2021
@posva posva moved this from In Review to Reviewed once, needs another review in 2.6.13 Mar 30, 2021
Zarad1993 and others added 2 commits March 30, 2021 11:31
Co-authored-by: Siddhesh Mhadnak <siddhesh.mhadnak@outlook.com>
@posva posva changed the title feat(warn): better message with no constructors props fix(warn): better message with no constructors props Mar 30, 2021
@posva posva moved this from Reviewed once, needs another review to Done in 2.6.13 Mar 30, 2021
@posva posva merged commit 6940131 into vuejs:dev Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Warn when the type of a prop isn't a constructor
3 participants