fix(compiler): Remove the waring for valid v-slot value #9917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch, although I think the proper fix would be introducing an extra branch for |
|
@yyx990803 I’d love to implement this. |
|
I just fixed CI - could you rebase against |
|
@yyx990803 Done. |
|
Hey @liximomo, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚 |
kiku-jw
pushed a commit
to kiku-jw/vue
that referenced
this pull request
Jun 18, 2019
dukegod
added a commit
to dukegod/vue
that referenced
this pull request
Jun 21, 2019
* commit 'bad3c326a3f8b8e0d3bcf07917dc0adf97c32351': (911 commits) chore: update sponsors [ci skip] (vuejs#10158) chore: fix sponsor url [ci skip] chore: update sponsors [ci skip] (vuejs#10136) chore: update sponsors [ci skip] (vuejs#10130) chore: update sponsors [ci skip] (vuejs#10113) chore(typo): fix comment typo (vuejs#10101) chore: update sponsors [ci skip] (vuejs#10064) Create FUNDING.yml chore: update sponsors [ci skip] (vuejs#10031) chore(typo): fix README tag mismatch (vuejs#9934) chore(typo): fix typo in comments (vuejs#9995) chore: update sponsors [ci skip] (vuejs#9970) chore: update sponsors [ci skip] (vuejs#9933) fix: fix function expression regex (vuejs#9922) fix(types): fix global namespace declaration for UMD bundle (vuejs#9912) fix(compiler): Remove the warning for valid v-slot value (vuejs#9917) polish: add warning when .native modifier is used on native HTML elements (vuejs#9884) test: fix running e2e test on windows (vuejs#9909) refactor: remove useless parameter to the function removeVnodes (vuejs#9914) test: separate failing test for TS 3.4 ... # Conflicts: # packages/weex-template-compiler/build.js # packages/weex-vue-framework/factory.js # packages/weex-vue-framework/index.js
Lostlover
pushed a commit
to Lostlover/vue
that referenced
this pull request
Dec 10, 2019
This was referenced Dec 21, 2019
This was referenced Jan 20, 2020
This was referenced Feb 24, 2020
This was referenced Mar 4, 2020
This was referenced Mar 28, 2020
This was referenced Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The Vue doc says that one can use destructuring props with fallback value as v-slot's value.
Actually, this will cause a warning.
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: