Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cyrillic "л" is replaced by Latin "n" in the anchor link #1815

Closed
1 task done
phenomen opened this issue Aug 29, 2019 · 17 comments · Fixed by #1855
Closed
1 task done

Cyrillic "л" is replaced by Latin "n" in the anchor link #1815

phenomen opened this issue Aug 29, 2019 · 17 comments · Fixed by #1855
Assignees
Labels
good first issue Good for newcomers has PR Has a related PR topic: docs-language:ru Used when working with docs in Russian type: bug Something isn't working

Comments

@phenomen
Copy link

phenomen commented Aug 29, 2019

  • I confirm that this is an issue rather than a question.

Bug report

Steps to reproduce

Repo: https://github.com/Phenomen/ose
Deployed version (with bugged anchor links): https://ose.phenomen.now.sh/classic-fantasy/

  1. Add a heading (h1-h6) with lowercase Cyrillic letter "л" (## Терминология)
  2. Check generated anchor link.

What is expected?

Anchor link is #терминология

What is actually happening?

Anchor link is: #терминоnогия
Cyrillic "л" is replaced by Latin "n" in the anchor link.

Other relevant information

Zeit is used for build and deploy. Result is the same as on local machine.

  • Output of npx vuepress info in my VuePress project:
@phenomen
Copy link
Author

phenomen commented Sep 1, 2019

@larionov
Copy link
Contributor

larionov commented Sep 1, 2019

Related: kentcdodds/match-sorter#57

Their solution is to replace diacritics with remove-accents instead.

@flozero flozero added good first issue Good for newcomers topic: docs-language:ru Used when working with docs in Russian type: bug Something isn't working labels Sep 6, 2019
@flozero
Copy link
Collaborator

flozero commented Sep 12, 2019

Do you think you can work on it ? We are using remove accents actually maybe bad configs

@larionov
Copy link
Contributor

@f3ltron I would like to try

@flozero
Copy link
Collaborator

flozero commented Sep 12, 2019

top @larionov ! Dont hesitate to ask me if you need some help about understanding part of vuepress

fork the project
create a branche
create the pr and reference to this issue :)

larionov added a commit to larionov/vuepress that referenced this issue Sep 12, 2019
larionov added a commit to larionov/vuepress that referenced this issue Sep 12, 2019
larionov added a commit to larionov/vuepress that referenced this issue Sep 12, 2019
larionov added a commit to larionov/vuepress that referenced this issue Sep 12, 2019
@larionov
Copy link
Contributor

@f3ltron Can you help me please?
I'm having trouble running tests locally, even on HEAD I get a bunch of tests are failing.
I do:

yarn
yarn bootstrap
yarn build 
yarn test

and I get this: https://gist.github.com/larionov/5e052b1de000297f6d14743a1baee327

@larionov
Copy link
Contributor

larionov commented Sep 12, 2019

Also just removing one dependency from shared-utils changes yarn.lock file considerably, updating a lot of dependencies and CONTRIBUTING.md seems to be outdated, there is no yarn clean command.

@flozero
Copy link
Collaborator

flozero commented Sep 12, 2019

i will have a look on it. I am a bit busy but i will have a look this weekend.

You are running tests on master branch ?

@flozero flozero self-assigned this Sep 12, 2019
@flozero
Copy link
Collaborator

flozero commented Sep 12, 2019

i tried myself locally

yarn bootstrap (it will do yarn tsc and install in every project)
yarn test

@larionov
Copy link
Contributor

larionov commented Sep 13, 2019

@f3ltron sorry, figured it out, realized that I had a very old fork of vuepress.
Please see the PR. #1855
For some reason it is not mentioned in the issue, what did I do wrong?

@flozero
Copy link
Collaborator

flozero commented Sep 13, 2019

Dont be sorry it's ok we all work together ! 💯

just start to pull master into your fork.

yarn boostrap
yarn test and it should work

Tell me more about what u doing now.

@larionov
Copy link
Contributor

I did the fix, opened the PR #1855 and waiting for the comments on it

@youngpirate32
Copy link

This error has affected me too, can you please see please

@namereva
Copy link

I have the same problem. How is progress?

@larionov
Copy link
Contributor

I will try to resolve the conflicts today

@larionov
Copy link
Contributor

Resolved

@v1talii-dev
Copy link

It also appears on the letter "й".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers has PR Has a related PR topic: docs-language:ru Used when working with docs in Russian type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants