Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix($theme-default): remove invalidate aria-labelledby on homepage title (fix #2273) #2277

Merged
merged 1 commit into from Aug 22, 2020

Conversation

billyyyyy3320
Copy link
Collaborator

Summary

#2273

When homepage title is disabled, the aria-labelledby point to nothing.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@billyyyyy3320 billyyyyy3320 changed the title fix($theme-default): disabling homepage title invalidate aria-labelledby (fix #2273) fix($theme-default): remove invalidate aria-labelledby on homepage title (fix #2273) Aug 22, 2020
@billyyyyy3320 billyyyyy3320 merged commit 94a7de4 into master Aug 22, 2020
@meteorlxy meteorlxy deleted the fix/main-title-aria-label branch January 26, 2021 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant