Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing examples for highlighting range of Lines in code blocks #2473

Closed
billyyyyy3320 opened this issue Jun 30, 2020 · 2 comments
Closed

Missing examples for highlighting range of Lines in code blocks #2473

billyyyyy3320 opened this issue Jun 30, 2020 · 2 comments
Labels
documentation Any issues related to documentation status: community assigned Community assigned

Comments

@billyyyyy3320
Copy link
Collaborator

Feature request

Line Highlighting in Code Blocks
Screen Shot 2020-07-01 at 00 07 59

There's only one example for this section.

However, it supports highlighting a range of lines, and even multiple ranges of lines!

In addition, import code highlighting works in the same way #2441

How should this be implemented in your opinion?

Add more description for this feature. Provide examples for highlighting a range of lines and multiple ranges of lines.

Are you willing to work on this yourself?

Yep, but still it's Contribution Welcome!
@billyyyyy3320 billyyyyy3320 added the documentation Any issues related to documentation label Jun 30, 2020
@billyyyyy3320 billyyyyy3320 changed the title Missing examples for Line Highlighting in Code Blocks Missing examples for highlighting range of Lines in code blocks Jun 30, 2020
@diogotcorreia
Copy link
Contributor

I don't mind making a PR for this later this week 😃

@billyyyyy3320
Copy link
Collaborator Author

@diogotcorreia Great! Welcome!

@bencodezen bencodezen added the status: community assigned Community assigned label Jul 2, 2020
diogotcorreia added a commit to diogotcorreia/vuepress that referenced this issue Jul 2, 2020
@diogotcorreia
docs($markdown): add missing examples for line highlighting (fix vuej…
55fd7ef 
…s#2473)

Signed-off-by: Diogo Correia <me@diogotc.com>
larionov pushed a commit to larionov/vuepress that referenced this issue Aug 19, 2020
@diogotcorreia
docs($markdown): add missing examples for line highlighting (fix vuej…
b33f8eb 
…s#2473) (vuejs#2477)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Any issues related to documentation status: community assigned Community assigned
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bencodezen @diogotcorreia @billyyyyy3320