Implementing a cache for the gettersProxy object creation #1546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erformance wth large number of modules/getters
ktsn
requested changes
Nov 9, 2019
src/store.js
Outdated
| Object.defineProperty(gettersProxy, localType, { | ||
| get: () => store.getters[type], | ||
| enumerable: true | ||
| if (cacheStore !== store) { |
There was a problem hiding this comment.
This way of clearing cache is not comprehensive. Getters may be changed via registerModule, unregisterModule or hotUpdate.
There was a problem hiding this comment.
Thank you so much for your reply! Could you give me a hint here?
I see that all those functions end up calling resetStoreVM, do you think that is the proper place to clear the cache?
That way I could also get rid of that cacheStore variable
…ll ssr performance wth large number of modules/getters" This reverts commit 2df536b.
ktsn
reviewed
Nov 9, 2019
|
Hey @frankcs, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚 |
This was referenced Nov 11, 2019
Closed
|
@ktsn can you check my issue too? vuejs/devtools#1058 |
This was referenced Nov 18, 2019
|
|
This was referenced Jan 21, 2020
This was referenced Mar 1, 2020
This was referenced Mar 12, 2020
This was referenced Mar 26, 2020
This was referenced Apr 1, 2020
vaga
pushed a commit
to vaga/vuex
that referenced
this pull request
Apr 20, 2020
…s#1546) * Implementing a cache for the gettersProxy object creation. Kill ssr performance wth large number of modules/getters * Revert "Implementing a cache for the gettersProxy object creation. Kill ssr performance wth large number of modules/getters" This reverts commit 2df536b. * Resetting the make local getters cache when the store gets updated * Changing cache to makeLocalGetters to instance internal state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1539