Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"types/logger.d.ts" file is missing from npm package #1788

Closed
jgerigmeyer opened this issue Jun 29, 2020 · 1 comment
Closed

"types/logger.d.ts" file is missing from npm package #1788

jgerigmeyer opened this issue Jun 29, 2020 · 1 comment
Labels
duplicate This issue or pull request already exists

Comments

@jgerigmeyer
Copy link

Version

3.5.0

Reproduction link

https://github.com/vuejs/vuex/blob/v3.5.0/package.json#L11-L16

Steps to reproduce

Run tsc or vue-cli-service build on repo with Vuex 3.5.0 installed.

What is expected?

No errors.

What is actually happening?

7:26 Cannot find module './logger' or its corresponding type declarations.
     5 |
     6 | import { mapState, mapMutations, mapGetters, mapActions, createNamespacedHelpers } from "./helpers";
  >  7 | import createLogger from "./logger";
       |                          ^
     8 |
     9 | export * from "./helpers";
    10 | export * from "./logger";
10:15 Cannot find module './logger' or its corresponding type declarations.
     8 |
     9 | export * from "./helpers";
  > 10 | export * from "./logger";
       |               ^
    11 |
    12 | export declare class Store<S> {
    13 |   constructor(options: StoreOptions<S>);

Fix: Add "types/helpers.d.ts", to package.json files config (https://github.com/vuejs/vuex/blob/v3.5.0/package.json#L11-L16).

@kiaking
Copy link
Member

kiaking commented Jun 29, 2020

Thanks for the report! Will close this one due to duplication #1788. The PR #1789 is open so we'll make a new release soon 🙏

@kiaking kiaking closed this as completed Jun 29, 2020
@kiaking kiaking added the duplicate This issue or pull request already exists label Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants