feat(types): adding logger type for logger plugin #1853

itomtom · 2020-10-18T14:39:34Z

createLogger options takes in logger which by default is console but
can be overridden with own logger.
Adding Ilogger for logger options params which expects log method to
be implemented

kiaking

Thank you so much for the PR! yeah we totally forgot about logger option hah...

I've made a comment. Could you have a look 🙏 ?

types/logger.d.ts

* createLogger options takes in logger which by default is console but can be overridden with own logger. * Adding Ilogger for logger options params which expects log method to be implemented

kiaking requested changes Oct 19, 2020

View reviewed changes

types/logger.d.ts Outdated Show resolved Hide resolved

kiaking added the types Related to typings only label Oct 19, 2020

itomtom force-pushed the feat/types/logger branch from 73a8ddd to 5a74586 Compare October 20, 2020 13:55

feat(types): adding logger type for logger plugin

b974e01

* createLogger options takes in logger which by default is console but can be overridden with own logger. * Adding Ilogger for logger options params which expects log method to be implemented

itomtom force-pushed the feat/types/logger branch from 5a74586 to b974e01 Compare October 21, 2020 17:44

kiaking approved these changes Oct 23, 2020

View reviewed changes

kiaking merged commit cb3198d into vuejs:dev Oct 23, 2020

dependabot bot mentioned this pull request Mar 17, 2021

Bump vuex from 3.1.3 to 3.6.2 rpocklin/phoenix#2

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(types): adding logger type for logger plugin #1853

feat(types): adding logger type for logger plugin #1853

itomtom commented Oct 18, 2020

kiaking left a comment

feat(types): adding logger type for logger plugin #1853

feat(types): adding logger type for logger plugin #1853

Conversation

itomtom commented Oct 18, 2020

kiaking left a comment

Choose a reason for hiding this comment