Skip to content
This repository has been archived by the owner on Jan 26, 2024. It is now read-only.

DOMException on url with multiple trailing slashes #136

Closed
2 of 5 tasks
bloodf opened this issue Aug 20, 2021 · 1 comment
Closed
2 of 5 tasks

DOMException on url with multiple trailing slashes #136

bloodf opened this issue Aug 20, 2021 · 1 comment
Labels
bug Bug reports VSF1 Issues in regards to VSF1

Comments

@bloodf
Copy link
Contributor

bloodf commented Aug 20, 2021

From vue-storefront created by aloupfor: vuestorefront/vue-storefront#4507

Current behavior

I open: https://demo.vuestorefront.io// (notice trailing //).
Page does not load properly.

https://demo.vuestorefront.io/////////////////////////// has the same behavior.

Expected behavior

I open: https://demo.vuestorefront.io// (notice trailing //).
Page load properly.

I do not know if it should display the same content as https://demo.vuestorefront.io or be a 404 error.

Steps to reproduce the issue

Open: https://demo.vuestorefront.io//

Repository

Can you handle fixing this bug by yourself?

  • YES
  • NO

Which Release Cycle state this refers to? Info for developer.

Pick one option.

  • This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
  • This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
  • This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Environment details

  • Browser: Chromium Version 73.0.3683.75
  • OS: Debian 9

Additional information

Error displayed in browser console tab:

vue-router.esm.js:1697 Uncaught (in promise) DOMException: Failed to execute 'replaceState' on 'History': A history state object with URL 'https:' cannot be created in a document with origin 'https://demo.vuestorefront.io' and URL 'https://demo.vuestorefront.io//'.
    at it (https://demo.vuestorefront.io/dist/vendor.e0b36c61b90a056a40d7.js:20:13257)
    at new e (https://demo.vuestorefront.io/dist/vendor.e0b36c61b90a056a40d7.js:20:19375)
    at new Dt (https://demo.vuestorefront.io/dist/vendor.e0b36c61b90a056a40d7.js:20:23038)
    at s (https://demo.vuestorefront.io/dist/app.e0b36c61b90a056a40d7.js:1:293169)
    at https://demo.vuestorefront.io/dist/app.e0b36c61b90a056a40d7.js:1:346891
    at https://demo.vuestorefront.io/dist/app.e0b36c61b90a056a40d7.js:1:346507
    at Object.next (https://demo.vuestorefront.io/dist/app.e0b36c61b90a056a40d7.js:1:346612)
    at https://demo.vuestorefront.io/dist/app.e0b36c61b90a056a40d7.js:1:345548
    at new Promise (<anonymous>)
    at j (https://demo.vuestorefront.io/dist/app.e0b36c61b90a056a40d7.js:1:345293)
@bloodf bloodf added bug Bug reports VSF1 Issues in regards to VSF1 labels Aug 20, 2021
@bloodf
Copy link
Contributor Author

bloodf commented Aug 20, 2021

@aloupfor thanks for reporting this issue. It is related with vsf-router vuejs/vue-router#2593 As I see it is fixed in v4 so I think that best way is just wait for it

@bloodf bloodf closed this as completed Aug 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug reports VSF1 Issues in regards to VSF1
Projects
None yet
Development

No branches or pull requests

1 participant