Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set extractCSS as default setting in nuxt.config.js #4890

Closed
andrzejewsky opened this issue Sep 18, 2020 · 1 comment
Closed

Set extractCSS as default setting in nuxt.config.js #4890

andrzejewsky opened this issue Sep 18, 2020 · 1 comment
Labels
backlog good first issue Tasks that requires just basic understanding of Vue Storefront Next Issues/bugs for Vue Storefront Next

Comments

@andrzejewsky
Copy link
Contributor

andrzejewsky commented Sep 18, 2020

Due to performance reasons and weird css ordering in production mode, would be nice to set extractCSS setting for nuxt.js

ref: https://nuxtjs.org/api/configuration-build/#extractcss

@andrzejewsky andrzejewsky added the Next Issues/bugs for Vue Storefront Next label Sep 18, 2020
@andrzejewsky andrzejewsky added this to Backlog in Next Core 1.0 via automation Sep 18, 2020
@filrak filrak added the good first issue Tasks that requires just basic understanding of Vue Storefront label Sep 21, 2020
@melmat melmat added the backlog label Feb 2, 2021
@RWave88
Copy link

RWave88 commented Sep 6, 2021

@andrzejewsky I would argue that setting extractCSS to true will actually get you into those ordering issues as described here: nuxt/nuxt#4219
although the task is closed - it's still reproducible even on the latest version of Nuxt.
Moreover in most cases extracting CSS into a separate chunk (especially for pages) will give you issues with performance rather than any gains due to the fact that serving one additional request is longer than parsing css from already loaded chunk. It can only be beneficial if you got external css of more than 1mb, but on the other hand if you have to serve so much CSS I would rather ask myself what made me create so much CSS in the project, usually most of it is dead/not used/not needed for a requested page state, so rather than extracting CSS you should reduce it's size

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog good first issue Tasks that requires just basic understanding of Vue Storefront Next Issues/bugs for Vue Storefront Next
Projects
No open projects
Next Core 1.0
  
Backlog
Development

No branches or pull requests

5 participants