From 79cd41d4399371ba3943dc48f6f2a1b0f6b2cd3b Mon Sep 17 00:00:00 2001 From: Elijah Kotyluk Date: Mon, 27 Dec 2021 00:55:10 -0800 Subject: [PATCH] fix(VCombobox): don't reset search when cleared (#14531) fixes #14507 --- packages/vuetify/src/components/VCombobox/VCombobox.ts | 2 +- .../src/components/VCombobox/__tests__/VCombobox.spec.ts | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/vuetify/src/components/VCombobox/VCombobox.ts b/packages/vuetify/src/components/VCombobox/VCombobox.ts index 6c0c85f137b..55c705aad55 100644 --- a/packages/vuetify/src/components/VCombobox/VCombobox.ts +++ b/packages/vuetify/src/components/VCombobox/VCombobox.ts @@ -179,7 +179,7 @@ export default VAutocomplete.extend({ } }, setValue (value?: any) { - VSelect.options.methods.setValue.call(this, value ?? this.internalSearch) + VSelect.options.methods.setValue.call(this, value === undefined ? this.internalSearch : value) }, updateEditing () { const value = this.internalValue.slice() diff --git a/packages/vuetify/src/components/VCombobox/__tests__/VCombobox.spec.ts b/packages/vuetify/src/components/VCombobox/__tests__/VCombobox.spec.ts index 9ccce8180d3..6488e5a8134 100644 --- a/packages/vuetify/src/components/VCombobox/__tests__/VCombobox.spec.ts +++ b/packages/vuetify/src/components/VCombobox/__tests__/VCombobox.spec.ts @@ -298,7 +298,7 @@ describe('VCombobox.ts', () => { expect(wrapper.vm.internalValue).toBe('') wrapper.vm.setValue(null) - expect(wrapper.vm.internalValue).toBeUndefined() + expect(wrapper.vm.internalValue).toBeNull() wrapper.vm.setValue(undefined) expect(wrapper.vm.internalValue).toBeUndefined() @@ -306,7 +306,7 @@ describe('VCombobox.ts', () => { wrapper.setData({ lazySearch: 'foo' }) wrapper.vm.setValue(null) - expect(wrapper.vm.internalValue).toBe('foo') + expect(wrapper.vm.internalValue).toBeNull() wrapper.vm.setValue(undefined) expect(wrapper.vm.internalValue).toBe('foo')