Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] VDataTable: add missing index variable in "item.<name>" scoped slot #10646

Closed
Djobot opened this issue Feb 21, 2020 · 2 comments · Fixed by #12605
Closed

[Feature Request] VDataTable: add missing index variable in "item.<name>" scoped slot #10646

Djobot opened this issue Feb 21, 2020 · 2 comments · Fixed by #12605
Assignees
@jacekkarczmarczyk
Labels
C: VDataTable VDatatable S: has PR The issue has a pending Pull Request T: feature A new feature
Milestone
v2.4.0

Comments

@Djobot
Copy link

Djobot commented Feb 21, 2020

Problem to solve

It would be very useful for adding a column with row index, and using index for custom stuff in a cell.

Proposed solution

Inside the scoped slot "item.<name>", the props should also contain the "index" property, like in the "item" scoped slot (cf #8199 and #8283).
@ghost ghost added the S: triage label Feb 21, 2020
@myleslee
Copy link
Contributor

Yes, please add 'index'. Otherwise I have to render columns manually using slot "item" for displaying the row index.

@MajesticPotatoe MajesticPotatoe added C: VDataTable VDatatable T: feature A new feature and removed S: triage labels Feb 24, 2020
@Djobot

This comment has been minimized.

Sign in to view
@alicjamusial alicjamusial mentioned this issue May 8, 2020
Closed
8 tasks
@jacekkarczmarczyk jacekkarczmarczyk added the S: has PR The issue has a pending Pull Request label May 8, 2020
@jacekkarczmarczyk jacekkarczmarczyk removed the S: has PR The issue has a pending Pull Request label Aug 26, 2020
@jacekkarczmarczyk jacekkarczmarczyk mentioned this issue Aug 26, 2020
Closed
This was referenced Oct 24, 2020
Closed
Closed
@jacekkarczmarczyk jacekkarczmarczyk added the S: has PR The issue has a pending Pull Request label Nov 12, 2020
@jacekkarczmarczyk jacekkarczmarczyk self-assigned this Nov 12, 2020
@jacekkarczmarczyk jacekkarczmarczyk added this to the v2.4.0 milestone Nov 12, 2020
jacekkarczmarczyk added a commit that referenced this issue Nov 12, 2020
@jacekkarczmarczyk
feat(VDataTable): index prop in item* slots
ecf50b2 
fixes #10646
@jacekkarczmarczyk jacekkarczmarczyk mentioned this issue Nov 12, 2020
Merged
8 tasks
@jacekkarczmarczyk jacekkarczmarczyk linked a pull request Nov 12, 2020 that will close this issue
feat(VDataTable): index prop in item* slots #12605
Merged
8 tasks
KaelWD added a commit that referenced this issue Nov 17, 2020
@KaelWD
Merge branch 'dev' into feat/#10646-index-in-data-table-item-slot
c8abab5
KaelWD pushed a commit that referenced this issue Nov 17, 2020
@jacekkarczmarczyk
feat(VDataTable): index prop in item* slots (#12605)
9daeb16 
Co-authored-by: Kael <kaelwd@gmail.com>

resolves #10646
@KaelWD KaelWD closed this as completed Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacekkarczmarczyk jacekkarczmarczyk

Labels
C: VDataTable VDatatable S: has PR The issue has a pending Pull Request T: feature A new feature
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging a pull request may close this issue.

feat(VDataTable): index prop in item* slots vuetifyjs/vuetify
5 participants
@myleslee @jacekkarczmarczyk @KaelWD @MajesticPotatoe @Djobot