Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Allow changing the tag for VBottomNav #11392

Closed
rudolfbyker opened this issue May 13, 2020 · 4 comments · Fixed by #12771, DepickereSven/Track-ify#123, true-runes/suikoden-election-2020-frontend#375, DepickereSven/Happiness#126 or Teahouse-Studios/mcwzh-meme-web-builder#114
Closed

[Feature Request] Allow changing the tag for VBottomNav #11392

rudolfbyker opened this issue May 13, 2020 · 4 comments · Fixed by #12771, DepickereSven/Track-ify#123, true-runes/suikoden-election-2020-frontend#375, DepickereSven/Happiness#126 or Teahouse-Studios/mcwzh-meme-web-builder#114
Assignees
@ElijahKotyluk
Labels
a11y Accessibility issue C: VItemGroup VItemGroup T: feature A new feature
Milestone
v2.4.0

Comments

@rudolfbyker
Copy link

Problem to solve

Screen readers like having the main site navigation in a <nav> element. See https://dequeuniversity.com/rules/axe/3.5/region . This is also good semantic HTML5 practice.

Proposed solution

Some Vuetify components allow changing their root tag from div to something else through the tag prop. VBottomNav should also support that prop.
@ghost ghost added the S: triage label May 13, 2020
@jacekkarczmarczyk jacekkarczmarczyk added a11y Accessibility issue C: VBottomNavigation VBottomNavigation labels May 13, 2020
@rudolfbyker
Copy link
Author

I'm not familiar with the Vuetify source code or Typescript, but I did some digging and it looks like the div is hard-coded in VItemGroup.ts on line 251, so this would have to start with making that configurable, if VBottomNavigation is to continue extending that.

@johnleider johnleider added T: feature A new feature S: triage and removed S: triage labels Dec 8, 2020
@johnleider johnleider added this to the v2.5.0 milestone Dec 8, 2020
@johnleider
Copy link
Member

Correct, this should be updated in VItemGroup. Quick win for v2.4.x

@johnleider johnleider modified the milestones: v2.5.0, v2.4.x Dec 10, 2020
@ElijahKotyluk ElijahKotyluk mentioned this issue Dec 14, 2020
Merged
8 tasks
@johnleider johnleider linked a pull request Dec 17, 2020 that will close this issue
feat(VItemGroup): add tag prop to component #12771
Merged
8 tasks
@KaelWD KaelWD modified the milestones: v2.4.x, v2.4.0 Dec 23, 2020
KaelWD pushed a commit that referenced this issue Dec 23, 2020
@ElijahKotyluk
feat(VItemGroup): add tag prop to component (#12771)
e3378fc 
resolves #11392
@KaelWD KaelWD closed this as completed Dec 23, 2020
@rudolfbyker
Copy link
Author

rudolfbyker commented Mar 16, 2021 •
edited

This has been updated in VItemGroup, but it's not in VBottomNav yet, so I think the issue should be re-opened.

johnleider added a commit that referenced this issue Mar 16, 2021
@johnleider
fix(VBottomNavigation): add missing tag functionality
4d627e9 
fixes #11392

VItemGroup was updated but the tag prop was never
added to VBottomNavigation
@johnleider
Copy link
Member

Good catch @rudolfbyker . Pushed a fix in 4d627e9

This was referenced Mar 17, 2021
Closed
Closed
Merged
This was referenced Mar 17, 2021
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Merged
Closed
Closed
Merged
Merged
Merged
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Merged
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ElijahKotyluk ElijahKotyluk

Labels
a11y Accessibility issue C: VItemGroup VItemGroup T: feature A new feature
Projects
None yet
Milestone
v2.4.0
5 participants
@johnleider @rudolfbyker @jacekkarczmarczyk @KaelWD @ElijahKotyluk