Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Typography): add text-pre-wrap utility class (#11772) #11772

Merged
merged 2 commits into from
Sep 29, 2020
Merged

feat(Typography): add text-pre-wrap utility class (#11772) #11772

merged 2 commits into from
Sep 29, 2020

Conversation

Shinigami92
Copy link
Contributor

Description

Add text-pre-wrap css utility class

fixes #11761

Motivation and Context

We already have a css utility class text-no-wrap. We can benefit from text-pre-wrap using it in content-class of v-tooltip and then using text containing \n

How Has This Been Tested?

Tested it locally adding the css utility class myself

Markup:

// Paste your FULL Playground.vue here

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@Shinigami92 Shinigami92 closed this Jul 1, 2020
@Shinigami92 Shinigami92 changed the title Feat/text pre wrap feat(Typography): Add text-pre-wrap Jul 1, 2020
@Shinigami92 Shinigami92 reopened this Jul 1, 2020
@Shinigami92 Shinigami92 marked this pull request as ready for review July 1, 2020 07:11
@johnleider johnleider self-requested a review September 29, 2020 17:34
@johnleider johnleider added this to the v2.3.x milestone Sep 29, 2020
@johnleider johnleider added framework Issues and Feature Requests that have needs framework-wide. T: feature A new feature labels Sep 29, 2020
@johnleider johnleider modified the milestones: v2.3.x, v2.4.0 Sep 29, 2020
@johnleider johnleider linked an issue Sep 29, 2020 that may be closed by this pull request
[Feature Request] Add text-pre-wrap #11761
Closed
@johnleider johnleider changed the title feat(Typography): Add text-pre-wrap feat(Typography): add text-pre-wrap utility class (#11772) Sep 29, 2020
@johnleider johnleider merged commit bf78f62 into vuetifyjs:dev Sep 29, 2020
@Shinigami92 Shinigami92 deleted the feat/text-pre-wrap branch September 30, 2020 06:00
jyburns pushed a commit to jyburns/vuetify that referenced this pull request Oct 11, 2020
@jyburns
feat(Typography): add text-pre-wrap utility class (vuetifyjs#11772)
9bac0b0 
resolves vuetifyjs#11761
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnleider johnleider johnleider approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
framework Issues and Feature Requests that have needs framework-wide. T: feature A new feature
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add text-pre-wrap
2 participants
@Shinigami92 @johnleider