-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(VCalendar): add support for object categories #12518
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should add at least one new unit test for this functionality
@nekosaur Let me know if there's anything else you need from me |
packages/vuetify/src/components/VCalendar/mixins/calendar-with-events.ts
Outdated
Show resolved
Hide resolved
There are still two unresolved comments |
@nekosaur sorry those comments were hidden |
TypeError: categoryMap_1.hasOwnProperty is not a function |
I think this should have been flagged as a breaking change. Is that expected or was that supposed to be passed back as a string so that there was no breaking change? |
Its not intended to be breaking, however its possible that there was an unforeseen regression in the |
Yup looks like it. I tracked it down in my code and then created an reproduction. Issue #12922 has been filed. |
@nquinn721 Hi Nathan. Thanks for adding this feature. However, it really needs to also update the docs. Beside the breaking change, I decided that I would embrace the category as an object approach only to waste an hour or because I figured that if the categories were objects, then the categories in the events must be objects too. Thanks for listening.... |
Description
Updated the category view to handle styles within each interval based off of category. I also added the ability to take an object in the category list and you can specify which prop to display as the text for category through 'category-text'. 'category-text' can be a string or a function where you can run logic to determine what to show.
Motivation and Context
Our app needed to color each interval in the calendar based off of category as well as we wanted meta data in the category.
How Has This Been Tested?
I've updated the unit tests to include my changes
Markup:
Types of changes
Checklist:
master
for bug fixes and documentation updates,dev
for new features and backwards compatible changes andnext
for non-backwards compatible changes).