-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(VSnackbar): keep snackbar open while mouseover #12599
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nekosaur
reviewed
Nov 12, 2020
Co-authored-by: Albert Kaaman <albert@kaaman.nu>
nekosaur
previously approved these changes
Nov 12, 2020
KaelWD
reviewed
Nov 13, 2020
KaelWD
reviewed
Nov 13, 2020
Any reason this shouldn't just be the default behaviour instead of a prop? |
Co-authored-by: Kael <kaelwd@gmail.com>
I was thinking that it could be a breaking change and we could make it default behaviour in 3.x |
I don't think it counts as a breaking change. |
I'm ok with that, do we need a prop to switch this behaviour off? |
KaelWD
changed the title
feat(VSnackbar): hold-on-hover prop
feat(VSnackbar): stop timeout when hovering snackbar
Nov 16, 2020
KaelWD
changed the title
feat(VSnackbar): stop timeout when hovering snackbar
feat(VSnackbar): keep snackbar open while mouseover
Nov 16, 2020
KaelWD
approved these changes
Nov 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addshold-on-hover
prop that stops the timer onmouseenter
and restarts onmouseleave
Motivation and Context
fixes #12494
How Has This Been Tested?
playground
Markup:
Types of changes
Checklist:
master
for bug fixes and documentation updates,dev
for new features and backwards compatible changes andnext
for non-backwards compatible changes).