-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(VDatePicker): show-adjacent-months
prop
#12603
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. The only thing I could see is that the text/background contrast ratio for the disabled selected dates is pretty bad, but I guess that's a separate issue.
Yeah, i'll try to fix in a separate PR |
attrs: { | ||
type: 'button', | ||
}, | ||
domProps: { | ||
disabled: this.disabled || !isAllowed, | ||
disabled: this.disabled || !isAllowed || isOtherMonth, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idk if disabled is right, the native ones are greyed out but still clickable: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/date
@@ -121,6 +121,7 @@ export default mixins( | |||
type: String, | |||
default: '$vuetify.datePicker.itemsSelected', | |||
}, | |||
showSiblingMonths: Boolean, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
showAdjacentMonths
? "sibling" implies possibly not directly next to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or just have it be default behaviour.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question as for hold-on-hover for snackbar - do we need a prop to turn this behaviour off?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so.
Let's keep the default behaviour same as in2.3, I've renamed prop to |
show-adjacent-months
prop
Is it possible to enable the days reflected by shownAdjacentMonths? |
Can we add a prop to allow the shownAdjacentsMonths clickable if isAllowed? |
Description
Adds possibility to display days from prev/next monhts
Motivation and Context
fixes #12237
How Has This Been Tested?
playground
Markup:
Types of changes
Checklist:
master
for bug fixes and documentation updates,dev
for new features and backwards compatible changes andnext
for non-backwards compatible changes).