Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(VTextField): add counter scoped slot #12634

Merged
merged 1 commit into from
Dec 23, 2020
Merged

feat(VTextField): add counter scoped slot #12634

merged 1 commit into from
Dec 23, 2020

Conversation

KaelWD
Copy link
Member

@KaelWD KaelWD commented Nov 17, 2020

resolves #9548

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

@KaelWD KaelWD added T: feature A new feature C: VTextField VTextField labels Nov 17, 2020
@KaelWD KaelWD added this to the v2.4.0 milestone Nov 17, 2020
@KaelWD KaelWD self-assigned this Nov 17, 2020
@KaelWD KaelWD modified the milestones: v2.4.0, v2.5.0 Nov 17, 2020
johnleider
johnleider reviewed Nov 17, 2020
View reviewed changes
Copy link
Member

@johnleider johnleider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only one comment regarding process.

packages/vuetify/src/components/VTextField/VTextField.ts Show resolved Hide resolved
@KaelWD KaelWD modified the milestones: v2.5.0, v2.4.0 Dec 23, 2020
@KaelWD KaelWD merged commit ed46cfb into dev Dec 23, 2020
@KaelWD KaelWD deleted the feat/9548-counter-slot branch December 23, 2020 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 left review comments

@johnleider johnleider johnleider left review comments

@shamilfrontend shamilfrontend shamilfrontend left review comments

Assignees

@KaelWD KaelWD

Labels
C: VTextField VTextField T: feature A new feature
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@KaelWD @Shinigami92 @johnleider @shamilfrontend