Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(VTextField): only show placeholder on focus if label is set #12635

Merged
merged 1 commit into from
Nov 17, 2020

Conversation

KaelWD
Copy link
Member

@KaelWD KaelWD commented Nov 17, 2020

Motivation and Context

resolves #12499

Having both label and placeholder displayed can be a usability problem as the placeholder looks very similar to typed text and could be confused with user input at a glance.

Potentially breaking change, you can't show both label and placeholder any more but this should be discouraged anyway.

EDIT: This is actually MD2 spec now:
image

Markup:

<template>
  <v-container>
    <v-text-field label="Label"></v-text-field>
    <v-text-field
      label="Label"
      placeholder="Placeholder"
    ></v-text-field>
    <v-text-field
      label="Label"
      placeholder="Placeholder"
      single-line
    ></v-text-field>
    <v-text-field
      label="Label"
      placeholder="Placeholder"
      value="Value"
    ></v-text-field>
  </v-container>
</template>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

resolves #12499

Having both label and placeholder displayed can be a usability problem
as the placeholder looks very similar to typed text and could be
confused with user input at a glance
@KaelWD KaelWD added T: enhancement Functionality that enhances existing features C: VTextField VTextField labels Nov 17, 2020
@KaelWD KaelWD self-assigned this Nov 17, 2020
@KaelWD KaelWD added this to the v2.4.0 milestone Nov 17, 2020
@KaelWD KaelWD requested a review from a team November 17, 2020 15:02
@KaelWD KaelWD changed the title feat(VTextField): only show placeholder on focus if label is present feat(VTextField): only show placeholder on focus if label is set Nov 17, 2020
@KaelWD KaelWD merged commit ff500ba into dev Nov 17, 2020
@KaelWD KaelWD deleted the feat/12499-temporary-placeholders branch November 17, 2020 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VTextField VTextField T: enhancement Functionality that enhances existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant