Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(VCalendar): update parser to return full category #12638

Merged
merged 4 commits into from
Nov 19, 2020
Merged

feat(VCalendar): update parser to return full category #12638

merged 4 commits into from
Nov 19, 2020

Conversation

nquinn721
Copy link
Contributor

@nquinn721 nquinn721 commented Nov 17, 2020

Update parser to return full category object

Description

The parser is currently returning {categoryName}. It needed to return full category

Motivation and Context

During interval styling we want to read the whole category instead of just the name

How Has This Been Tested?

Wrote a unit test for interval styling to make sure full category is being passed.

Markup:

<template>
  <v-container>
    <v-calendar
      color="primary"
      type="category"
      :categories="['Jeff', 'Nate']"
      category-show-all
      :events="events"
      :interval-style="intervalStyle"
    />
  </v-container>
</template>

<script>
export default {
  data: () => ({
    events: [
      {
        name: "Nate",
        category: "Nate",
        start: new Date(),
        end: new Date()
      }
    ]
  }),
  methods: {
    intervalStyle(obj){
      console.log(obj.category)
    }
  }
};
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@johnleider johnleider requested a review from a team November 17, 2020 20:10
@dsseng dsseng changed the title updated parser to return full category feat(VCalendar): update parser to return full category Nov 18, 2020
@nekosaur nekosaur merged commit e2200c3 into vuetifyjs:dev Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants