Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VCard): Incorrect positioning for v-card-actions in v-dialog #12734

Conversation

NabeelAhmed314
Copy link
Contributor

@NabeelAhmed314 NabeelAhmed314 commented Dec 5, 2020

fixes #10605

Incorrect positioning for v-card-actions when v-card is used in v-dialog is fixed by changing the default padding for v-card-actions to get it into correct position.

Description

Changed default padding for v-card-actions in variables file in order to make it correctly positioned .
fixes #10605

Motivation and Context

In order to start phase # 1 of Vuetify Titan all bugs with vcard had to be resolved.
Resolves Following Issue.
#10605

How Has This Been Tested?

This has been tested visually.

Markup:

<template>
  <v-container>
    <v-dialog v-model="showDialog">
      <v-card>
        <v-card-title>This is positioned correctly</v-card-title>
        <v-card-subtitle>This is positioned too far to the left</v-card-subtitle>
        <v-card-text>
          Lorem ipsum dolor sit amet, consectetur adipiscing elit. Quisque in ipsum purus. Vestibulum non diam ultricies, scelerisque ex vel, commodo sem. Phasellus blandit vehicula arcu, in dignissim magna. Nullam et augue sit amet eros dictum feugiat. Nam mi lorem, interdum non elementum vitae, sollicitudin nec mi. Phasellus facilisis enim sit amet porttitor dictum. Sed molestie ex vitae augue convallis blandit. Nulla a dapibus tortor, eu accumsan urna. Fusce varius turpis sed justo pellentesque pulvinar. Morbi eu leo nec ipsum elementum ullamcorper. Pellentesque at urna risus. Aliquam consequat id velit et elementum.
        </v-card-text>
        <v-card-actions>
          <v-btn>Click Me</v-btn>
        </v-card-actions>
      </v-card>
    </v-dialog>
    <v-card>
      <v-card-title>This is positioned correctly</v-card-title>
      <v-card-subtitle>This is positioned too far to the left</v-card-subtitle>
      <v-card-text>
        Lorem ipsum dolor sit amet, consectetur adipiscing elit. Quisque in ipsum purus. Vestibulum non diam ultricies, scelerisque ex vel, commodo sem. Phasellus blandit vehicula arcu, in dignissim magna. Nullam et augue sit amet eros dictum feugiat. Nam mi lorem, interdum non elementum vitae, sollicitudin nec mi. Phasellus facilisis enim sit amet porttitor dictum. Sed molestie ex vitae augue convallis blandit. Nulla a dapibus tortor, eu accumsan urna. Fusce varius turpis sed justo pellentesque pulvinar. Morbi eu leo nec ipsum elementum ullamcorper. Pellentesque at urna risus. Aliquam consequat id velit et elementum.
      </v-card-text>
      <v-card-actions>
        <v-btn>Click Me</v-btn>
      </v-card-actions>
    </v-card>
  </v-container>
</template>

<script>
  export default {
    data: () => ({
      showDialog: () => true,
    }),
  }
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

Copy link
Member

@MajesticPotatoe MajesticPotatoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This causes issues with cards outside of dialogs (they receive to much padding).

8px 24px works fine inside the dialog, outside the dialog it would need to be 8px 16px.
would suggest changing this to 8px 16px and then applying 24px to VDialog sass/vars

@MajesticPotatoe MajesticPotatoe added C: VCard VCard C: VDialog VDialog md2 The issue pertains to Material Spec 2 T: bug Functionality that does not work as intended/expected labels Dec 8, 2020
@NabeelAhmed314
Copy link
Contributor Author

@MajesticPotatoe I have added the changes you have requested. Kindly review these changes.

MajesticPotatoe
MajesticPotatoe previously approved these changes Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VCard VCard C: VDialog VDialog md2 The issue pertains to Material Spec 2 T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] Incorrect positioning for v-card-actions in v-dialog
2 participants