Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert(VTextField): partial revert of #12554 #12757

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Conversation

MajesticPotatoe
Copy link
Member

@MajesticPotatoe MajesticPotatoe commented Dec 9, 2020

Description

Partial revert of #12554.

Motivation and Context

#12554 introduced unintended regression of the functionality of hide-details="auto"
resolves #12755

How Has This Been Tested?

visual | jest

Markup:

<template>
  <v-container>
    <v-checkbox
      v-model="hasMessage"
      label="Show Message"
    />
    <v-checkbox
      v-model="hideDetails"
      label="hideDetails"
    />
    <v-row>
      <v-col>
        <v-text-field
          label="Test Message Animation"
          :hide-details="d"
          :error="hasMessage"
          :messages="hasMessage ? 'Message to see' : undefined"
        />
      </v-col>
      <v-col>
        <v-radio-group
          :error="hasMessage"
          :messages="hasMessage ? 'Message to see' : undefined"
          hide-details="auto"
        >
          <v-radio label="Test" />
        </v-radio-group>
      </v-col>
    </v-row>
  </v-container>
</template>

<script>
  export default {
    data: () => ({
      hasMessage: false,
      hideDetails: false,
    }),
    computed: {
      d () {
        return this.hideDetails ? this.hideDetails : 'auto'
      },
    },
  }
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@MajesticPotatoe MajesticPotatoe added C: VTextField VTextField T: bug Functionality that does not work as intended/expected T: regression Something that used to work but we broke labels Dec 9, 2020
@MajesticPotatoe MajesticPotatoe self-assigned this Dec 9, 2020
@MajesticPotatoe MajesticPotatoe merged commit d2957b1 into master Dec 9, 2020
@MajesticPotatoe MajesticPotatoe deleted the revert/12554 branch December 9, 2020 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VTextField VTextField T: bug Functionality that does not work as intended/expected T: regression Something that used to work but we broke
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] hide-details auto keeps rendering empty details sections
1 participant