Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert(VDivider): vertical v-divider not displayed when inside div #12758

Conversation

MajesticPotatoe
Copy link
Member

@MajesticPotatoe MajesticPotatoe commented Dec 9, 2020

Description

Reverts #12735

Motivation and Context

regression caused by #12735
resolves #12752

How Has This Been Tested?

visual

Markup:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@MajesticPotatoe MajesticPotatoe added T: bug Functionality that does not work as intended/expected T: regression Something that used to work but we broke C: VDivider VDivider labels Dec 9, 2020
@MajesticPotatoe MajesticPotatoe self-assigned this Dec 9, 2020
@MajesticPotatoe MajesticPotatoe merged commit f5a234a into master Dec 9, 2020
@MajesticPotatoe MajesticPotatoe deleted the revert-12735-fix/8656-vertical-vdivider-not-displayed-inside-div branch December 9, 2020 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VDivider VDivider T: bug Functionality that does not work as intended/expected T: regression Something that used to work but we broke
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] Vertical v-divider does not take up available space anymore
1 participant