Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VImg): SVG size wrong after uncached load #12825

Merged
merged 7 commits into from
Dec 23, 2020
Merged

Conversation

YipingRuan
Copy link
Contributor

Description

fix #12784 cause new bug:
image

Motivation and Context

How Has This Been Tested?

visually

Markup:

<template>
  <div id="app">
    <v-app>
      <v-container>
        <v-row>
          svg with height/width
          <v-img src="https://dev.w3.org/SVG/tools/svgweb/samples/svg-files/AJ_Digital_Camera.svg"></v-img>
        </v-row>
        <v-row>
          svg no given height/width
          <v-img src="https://dev.w3.org/SVG/tools/svgweb/samples/svg-files/410.svg"></v-img>
        </v-row>
        <v-row>
          data-url:
          <v-img src="data:image/svg+xml,%3Csvg xmlns='http://www.w3.org/2000/svg'%3E%3Ccircle r='50' cx='50' cy='50' fill='tomato'/%3E%3Ccircle r='41' cx='47' cy='50' fill='orange'/%3E%3Ccircle r='33' cx='48' cy='53' fill='gold'/%3E%3Ccircle r='25' cx='49' cy='51' fill='yellowgreen'/%3E%3Ccircle r='17' cx='52' cy='50' fill='lightseagreen'/%3E%3Ccircle r='9' cx='55' cy='48' fill='teal'/%3E%3C/svg%3E" />
        </v-row>
      </v-container>
    </v-app>
  </div>
</template>

<script>
  export default {

  }
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@YipingRuan YipingRuan closed this Dec 23, 2020
@YipingRuan YipingRuan reopened this Dec 23, 2020
@YipingRuan YipingRuan marked this pull request as draft December 23, 2020 10:45
@YipingRuan
Copy link
Contributor Author

YipingRuan commented Dec 23, 2020

Include fix to stop svg polling forever (no size)

@YipingRuan YipingRuan added this to the 2.4.1 milestone Dec 23, 2020
@YipingRuan YipingRuan self-assigned this Dec 23, 2020
@YipingRuan YipingRuan added C: VImg VImg T: bug Functionality that does not work as intended/expected labels Dec 23, 2020
@YipingRuan YipingRuan linked an issue Dec 23, 2020 that may be closed by this pull request
@YipingRuan YipingRuan marked this pull request as ready for review December 23, 2020 12:07
@KaelWD KaelWD modified the milestones: 2.4.1, v2.3.x Dec 23, 2020
@KaelWD KaelWD changed the title fix(VImg): SVG size wrong during first loading fix(VImg): SVG size wrong after uncached load Dec 23, 2020
@KaelWD KaelWD merged commit a6e2e44 into master Dec 23, 2020
@KaelWD KaelWD deleted the Fix/#11426_mising_svg_size branch December 23, 2020 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VImg VImg T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] v-img with svg is not loading in Firefox
2 participants