Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report][2.5.0] Multiple drawer not supported due to bad application service code #13665

Closed
Caceresenzo opened this issue May 17, 2021 · 4 comments · Fixed by #14450
Closed

Comments

@Caceresenzo
Copy link

Environment

Vuetify Version: 2.5.0
Vue Version: 2.6.12
Browsers: Chrome 90.0.4430.212
OS: Windows 10

Steps to reproduce

Click on go to x page

Expected Behavior

Handle multiple mavigation drawer in the application.left variable

Actual Behavior

Only handling the last one by overwriting the value

this.application[location] = { [uid]: size }

Possible fix

this.application[location][uid] = size

Reproduction Link

https://codepen.io/caceresenzo/pen/BaWLNxQ?editors=1011

@ghost ghost added the S: triage label May 17, 2021
@KaelWD
Copy link
Member

KaelWD commented May 17, 2021

@johnleider was this really removed just to support keep-alive? (#9797)

Caceresenzo added a commit to atetu/Ft_transcendence that referenced this issue May 17, 2021
@johnleider
Copy link
Member

@johnleider was this really removed just to support keep-alive? (#9797)

At the time it was also useful in resolving an animation issue with components being registered/unregistered and causing weight content changes or otherwise janky behavior.

@Caceresenzo
Copy link
Author

I heavily depends on multiple drawer, I was having no choice but to fix the problem in any kind of way.

The first solution was to patch the dist files. It completly broke when a new version released.... (kind of expected)

The second (and current) solution is to replace the current application function as soon as possible:

$vuetify.application.register = function (
    uid: number,
    location: any,
    size: number
  ) {
    this.application[location][uid] = size
    this.update(location)
  }

This is a dirty hack, and will propably break if the team decide to fix the original problem.

Caceresenzo added a commit to atetu/Ft_transcendence that referenced this issue Jul 16, 2021
vuetifyjs/vuetify#13665 (comment)

As for the back twice, it has been fixed in newer version of vuetify
johnleider added a commit that referenced this issue Nov 30, 2021
fixes #13665

the use-case that this was changed for was very
convoluted and niche and ultimately has caused
a regression.
@johnleider johnleider modified the milestones: v2.5.x, v2.6.x Nov 30, 2021
johnleider added a commit that referenced this issue Dec 1, 2021
@Caceresenzo
Copy link
Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants