Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VCalendar): missing events under certain circumstances #13763

Merged
merged 1 commit into from
Jun 14, 2021

Conversation

jacekkarczmarczyk
Copy link
Member

@jacekkarczmarczyk jacekkarczmarczyk commented Jun 5, 2021

events in

const { parent, events, more } = eventsMap[date]
were not sorted by the position (bounding rect), so if the first event was outside of the calendar cell then hide was set to true and all next events were treated as hidden. This PR sorts event by the bottom position, not sure if there's a way to get events properly sorted in getEventsMap

fixes #13720

How Has This Been Tested?

playground

Markup:

https://gist.githubusercontent.com/jacekkarczmarczyk/cd30d957a7d2a629e2bdd738d2fc6d61/raw/eaaf8d89c770c66fc27015bbeb382a27e5ba5ef1/vuetify-13720-playground.vue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@jacekkarczmarczyk jacekkarczmarczyk added T: bug Functionality that does not work as intended/expected C: VCalendar VCalendar labels Jun 5, 2021
@jacekkarczmarczyk jacekkarczmarczyk self-assigned this Jun 5, 2021
@johnleider johnleider added this to the v2.5.x milestone Jun 11, 2021
@johnleider johnleider requested a review from KaelWD June 11, 2021 17:23
@johnleider johnleider changed the title fix(VCalendar): events are not displaying in certain conditions fix(VCalendar): missing events under certain circumstances Jun 14, 2021
@johnleider johnleider merged commit 8226cc9 into master Jun 14, 2021
@johnleider johnleider deleted the fix/#13720-calendar-missing-events branch June 14, 2021 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VCalendar VCalendar T: bug Functionality that does not work as intended/expected
Projects
None yet
2 participants