Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VMenu): activator should not return non Element nodes #13774

Merged
merged 4 commits into from
Jun 14, 2021

Conversation

Tofandel
Copy link
Contributor

@Tofandel Tofandel commented Jun 7, 2021

Description

Fixes #13755

Motivation and Context

How Has This Been Tested?

Markup:

// Paste your FULL Playground.vue here

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@Tofandel Tofandel marked this pull request as draft June 7, 2021 21:01
@Tofandel Tofandel marked this pull request as ready for review June 7, 2021 21:05
@johnleider johnleider requested a review from KaelWD June 11, 2021 16:16
@KaelWD KaelWD added C: VMenu VMenu T: bug Functionality that does not work as intended/expected and removed S: triage labels Jun 13, 2021
@KaelWD KaelWD added this to the v2.5.x milestone Jun 14, 2021
@KaelWD KaelWD changed the title fix(Activatable): get activator should not return non Element nodes fix(VMenu): activator should not return non Element nodes Jun 14, 2021
@KaelWD KaelWD merged commit 25e80a1 into vuetifyjs:master Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VMenu VMenu T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report][2.5.3] v-navigation-drawer with expand-on-hover throws console errors when hovered
3 participants