Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VCard): set correct radius for direct VAvatar children #13789

Merged
merged 2 commits into from
Jun 14, 2021
Merged

fix(VCard): set correct radius for direct VAvatar children #13789

merged 2 commits into from
Jun 14, 2021

Conversation

gprst
Copy link
Contributor

@gprst gprst commented Jun 11, 2021

Description

A sass rule makes a VAvatar that is the first child of a VCard look weird :

image

My change makes it back to normal :

image

It doesn't change modifiers, like tile :

image

How Has This Been Tested?

I tested it visually. I am not comfortable with unit testing with a Vue framework but am willing to implement unit tests if they are required here, with some direction pointing

Markup:

<template>
  <v-container>
    <v-row>
      <v-card>
        <v-avatar size="40" color="primary">
          <span class="white--text text-h5">A</span>
        </v-avatar>
      </v-card>
    </v-row>
    <v-row>
      <v-card>
        <v-avatar tile size="40" color="primary">
          <span class="white--text text-h5">B</span>
        </v-avatar>
      </v-card>
    </v-row>
    <v-row>
      <v-card>
        <v-avatar rounded size="40" color="primary">
          <span class="white--text text-h5">C</span>
        </v-avatar>
      </v-card>
    </v-row>
  </v-container>
</template>

<script>
  export default {
    data: () => ({
    //
    }),
  }
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

Copy link
Member

@KaelWD KaelWD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would apply to :last-child as well.

@gprst gprst changed the title fix(VCard): fix top border radius when first child is VAvatar fix(VCard): fix border radius for direct VAvatar children Jun 13, 2021
@gprst
Copy link
Contributor Author

gprst commented Jun 13, 2021

You're right ! Here, done ! I renamed the PR as well, tell me if the name sounds good

@johnleider johnleider added C: VCard VCard T: bug Functionality that does not work as intended/expected labels Jun 14, 2021
@johnleider johnleider added this to the v2.5.x milestone Jun 14, 2021
Copy link
Member

@johnleider johnleider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working properly in v3 and does not require a port.

@johnleider johnleider changed the title fix(VCard): fix border radius for direct VAvatar children fix(VCard): set correct radius for direct VAvatar children Jun 14, 2021
@johnleider johnleider merged commit 00b29ba into vuetifyjs:master Jun 14, 2021
@gprst gprst deleted the fix/v-card-first-child-v-avatar branch June 25, 2021 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VCard VCard T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants