Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): add missing goTo types #13812

Merged
merged 2 commits into from
Jun 22, 2021
Merged

fix(types): add missing goTo types #13812

merged 2 commits into from
Jun 22, 2021

Conversation

jacekkarczmarczyk
Copy link
Member

fixes #9648

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@jacekkarczmarczyk jacekkarczmarczyk added this to the v2.5.x milestone Jun 17, 2021
@jacekkarczmarczyk jacekkarczmarczyk self-assigned this Jun 17, 2021
@jacekkarczmarczyk jacekkarczmarczyk changed the title fix(types): add missing types fix(types): goTo - add missing types Jun 17, 2021
@KaelWD
Copy link
Member

KaelWD commented Jun 18, 2021

What's the difference between maps/vuetify and maps/$vuetify?

@jacekkarczmarczyk
Copy link
Member Author

What's the difference between maps/vuetify and maps/$vuetify?

No idea, just updated signature in both but I guess only one is used

@KaelWD KaelWD changed the title fix(types): goTo - add missing types fix(types): add missing goTo types Jun 22, 2021
@KaelWD KaelWD merged commit 9f6d0c0 into master Jun 22, 2021
@KaelWD KaelWD deleted the fix/#9648-goto-types branch June 22, 2021 13:47
@johnleider johnleider added E: goTo GoTo composable and removed goTo labels Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E: goTo GoTo composable typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] No typings for import goTo function
3 participants