Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VMenu): apply position:relative to v-app #13823

Merged
merged 1 commit into from
Jun 19, 2021
Merged

Conversation

Tofandel
Copy link
Contributor

Description

fixes #13821

Motivation and Context

All the calculations assume the v-app was relatively positioned, except it wasn't, only the v-application--wrap was relatively positioned leading to the demonstrated bug

How Has This Been Tested?

Visually

Markup:

// Paste your FULL Playground.vue here

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.

@KaelWD KaelWD changed the title fix(Menuable): positionning fix(VMenu): apply position:relative to v-app Jun 19, 2021
@KaelWD KaelWD merged commit d8679b9 into vuetifyjs:master Jun 19, 2021
@KaelWD KaelWD added C: VMenu VMenu T: bug Functionality that does not work as intended/expected T: regression Something that used to work but we broke labels Jun 19, 2021
@KaelWD KaelWD added this to the v2.5.x milestone Jun 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VMenu VMenu T: bug Functionality that does not work as intended/expected T: regression Something that used to work but we broke
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report][2.5.4] v-tooltip positioning broken if html/body element has margin set
2 participants