Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VCombobox): re-compute menu items before setting index #13825

Merged
merged 2 commits into from
Jun 28, 2021

Conversation

KaelWD
Copy link
Member

@KaelWD KaelWD commented Jun 19, 2021

fixes #12567

Markup:

<template>
  <v-app>
    <v-container>
      <v-combobox :items="items"></v-combobox>
      <v-autocomplete :items="items"></v-autocomplete>
      <v-select :items="items"></v-select>
    </v-container>
  </v-app>
</template>

<script>
  export default {
    data: () => ({
      items: ['a', 'b', 'c', 'd', 'e', 'f'],
    }),
  }
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

@KaelWD KaelWD added C: VCombobox VCombobox C: VSelect VSelect help wanted We are looking for community help T: bug Functionality that does not work as intended/expected labels Jun 19, 2021
@KaelWD KaelWD self-assigned this Jun 19, 2021
@KaelWD KaelWD removed the help wanted We are looking for community help label Jun 19, 2021
@KaelWD KaelWD added this to the v2.5.x milestone Jun 19, 2021
@KaelWD KaelWD marked this pull request as ready for review June 19, 2021 16:09
@johnleider johnleider merged commit 8c0e2bc into master Jun 28, 2021
@johnleider johnleider deleted the fix/12567-combobox-keyboard branch June 28, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VCombobox VCombobox C: VSelect VSelect T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] Inconsistent Behaviour when using v-combobox with keyboard
2 participants