Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VStepperStep): editable step tab navigation #14036

Merged
merged 2 commits into from Dec 7, 2021

Conversation

lentyaevpk
Copy link
Contributor

Description

Added tab navigation for editable stepper steps.
Fixes #14022

How Has This Been Tested?

Visually

Markup:

// Paste your FULL Playground.vue here
<template>
  <v-stepper>
    <v-stepper-header>
      <v-stepper-step
        editable
        step="1"
      >
        Select campaign settings
      </v-stepper-step>

      <v-divider></v-divider>

      <v-stepper-step
        editable
        step="2"
      >
        Create an ad group
      </v-stepper-step>

      <v-divider></v-divider>

      <v-stepper-step
        step="3"
        editable
      >
        Create an ad
      </v-stepper-step>
    </v-stepper-header>
  </v-stepper>
</template>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@glen-84 glen-84 added C: VStepper VStepper T: bug Functionality that does not work as intended/expected labels Aug 8, 2021
@johnleider johnleider self-requested a review November 29, 2021 16:28
@johnleider johnleider added the a11y Accessibility issue label Nov 29, 2021
@johnleider johnleider added this to the v2.6.x milestone Dec 7, 2021
@johnleider johnleider merged commit 256fa93 into vuetifyjs:master Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility issue C: VStepper VStepper T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report][2.4.9] Editable Stepper Header Not Keyboard Accessible
3 participants