Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report][2.6.0] Null not handled properly in v-autocomplete (and v-select) #14421

Closed
billerby opened this issue Nov 21, 2021 · 0 comments · Fixed by #14464
Closed

[Bug Report][2.6.0] Null not handled properly in v-autocomplete (and v-select) #14421

billerby opened this issue Nov 21, 2021 · 0 comments · Fixed by #14464
Assignees
@KaelWD
Labels
C: VSelect VSelect T: bug Functionality that does not work as intended/expected
Milestone
v2.6.x

Comments

@billerby
Copy link
Contributor

Environment

Vuetify Version: 2.6.0
Last working version: 2.3.15
Vue Version: 2.6.11
Browsers: Firefox 94.0
OS: Linux x86_64

Steps to reproduce

So this is a regression bug that was introduced when #12517 was fixed. When the array of autocomplete items contains a null item the error appears.

Expected Behavior

The autocomplete alternatives should render correctly.

Actual Behavior

Well it "crashes" on a NullPointer reference and the autocomplete becomes somewhat unusable.

Reproduction Link

https://codepen.io/billerby/pen/qBXwpPa

Other comments

Quite a few users seems to have ran into this issue. See the comments in #12517
billerby added a commit to billerby/vuetify that referenced this issue Dec 5, 2021
@billerby
Check that item. fixes vuetifyjs#14421
2528f14
billerby added a commit to billerby/vuetify that referenced this issue Dec 5, 2021
@billerby
Null items should not be added to list of unique items. fixes vuetify…
411dfc8 
…js#14421
@billerby billerby mentioned this issue Dec 5, 2021
Merged
4 tasks
billerby added a commit to billerby/vuetify that referenced this issue Dec 5, 2021
@billerby
fix(VSelect): Do not keep null items when filtering duplicates
80905ea 
resolves vuetifyjs#14421
@KaelWD KaelWD added C: VSelect VSelect T: bug Functionality that does not work as intended/expected and removed S: triage labels Dec 14, 2021
@KaelWD KaelWD added this to the v2.6.x milestone Dec 14, 2021
@KaelWD KaelWD self-assigned this Dec 14, 2021
KaelWD pushed a commit that referenced this issue Dec 14, 2021
@billerby
fix(VSelect): Do not keep null items when filtering duplicates (#14464)
8fd3510 
fixes #14421
@KaelWD KaelWD mentioned this issue Dec 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KaelWD KaelWD

Labels
C: VSelect VSelect T: bug Functionality that does not work as intended/expected
Projects
None yet
Milestone
v2.6.x
Development

Successfully merging a pull request may close this issue.

fix(VSelect): Do not keep null items when filtering duplicates billerby/vuetify
2 participants
@billerby @KaelWD