Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(application): allow use of multiple drawers #14450

Merged
merged 1 commit into from Dec 1, 2021

Conversation

johnleider
Copy link
Member

Description

The use-case that this was changed for was very convoluted and niche and ultimately has caused
a regression. This PR reverts the change made in b1058f3

Motivation and Context

fixes #13665

How Has This Been Tested?

jest/visually

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

fixes #13665

the use-case that this was changed for was very
convoluted and niche and ultimately has caused
a regression.
@johnleider johnleider added T: bug Functionality that does not work as intended/expected Service: Application labels Nov 30, 2021
@johnleider johnleider added this to the v2.6.x milestone Nov 30, 2021
@johnleider johnleider self-assigned this Nov 30, 2021
@johnleider johnleider changed the title fix(application): revert change made in b1058f3 fix(application): allow use of multiple drawers Dec 1, 2021
@johnleider johnleider merged commit 85a1186 into master Dec 1, 2021
@johnleider johnleider deleted the fix/13665-navigation-drawer branch December 1, 2021 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Service: Application T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report][2.5.0] Multiple drawer not supported due to bad application service code
1 participant