fix(VTabs): correctly set active state with exact prop #14500
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The v-tabs component didn't move the slider if the v-tab had the property "exact"
Description
After investigating, it came from the mixin routable,
The value of "exactActiveClass" was not checked before assigning to the path, resulting in
'_vnode.data.class.undefined
I change the code to fall back on
proxyClass
ifexactActiveClass
is undefinedAs a precaution I did the same for
activeClass
even if it's not needed for resolving this issuethe bug was introduced by PR #14207
Motivation and Context
Resolves #14431
Resolves #14459
How Has This Been Tested?
didn't add unit tests
Markup:
Playground.vue
Types of changes
Checklist:
master
for bug fixes and documentation updates,dev
for new features and backwards compatible changes andnext
for non-backwards compatible changes).