Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report][2.6.2] VNavigationDrawe ,attr expandOnHover always enable(true) #14555

Closed
iam993 opened this issue Dec 31, 2021 · 15 comments
Closed
Assignees
Labels
C: VNavigationDrawer VNavigationDrawer T: bug Functionality that does not work as intended/expected T: regression Something that used to work but we broke
Milestone

Comments

@iam993
Copy link

iam993 commented Dec 31, 2021

Environment

Vuetify Version: 2.6.2
Last working version: 2.6.2
Vue Version: 2.6.9
Browsers: Chrome 89.0.4389.90
OS: Windows 10

Steps to reproduce

/

Expected Behavior

/

Actual Behavior

/

Reproduction Link

https://codepen.io/

Other comments

/

@KareemDa
Copy link
Contributor

KareemDa commented Jan 1, 2022

@iam993
What is the problem? please provide a description and reproduction link

@Ahriana
Copy link

Ahriana commented Jan 2, 2022

im not sure if this the same issue but since the last release ive had the navigation draw push the content of the page perminantly likes its always expanded
image

i will look into seeing if i can repo it in code pen later

@iam993
Copy link
Author

iam993 commented Jan 2, 2022

@KareemDa
just like vuetify doc.
https://vuetifyjs.com/en/components/navigation-drawers/#mini-variant
when [:mini-variant.sync] is binded, expandOnHover is true

@iam993
Copy link
Author

iam993 commented Jan 2, 2022

@Ahriana
I also found the same problem, everything is normaly in ver 2.6.1

@Ahriana
Copy link

Ahriana commented Jan 2, 2022

yeah ive just bypassed the padding at the moment until i have the time to look into it more style="padding-left: 64px"

@hadalin
Copy link

hadalin commented Jan 4, 2022

The problem could be missing this if (this.expandOnHover) { here.

@Ahriana
Copy link

Ahriana commented Jan 4, 2022

i dont think so as its applies earlier in the file instead, the behaviour is as if the side bar is always expanded, but the expand behaviour is the same as before but the content is pushed over as if the minivariant is being ignored in style but not behaviour

@KaelWD KaelWD added C: VNavigationDrawer VNavigationDrawer T: bug Functionality that does not work as intended/expected T: regression Something that used to work but we broke and removed S: triage labels Jan 4, 2022
@KaelWD KaelWD added this to the v2.6.x milestone Jan 4, 2022
@KaelWD KaelWD self-assigned this Jan 6, 2022
@KaelWD
Copy link
Member

KaelWD commented Jan 6, 2022

Related: #13309

@Ahriana I don't see that, please open a new issue if you can reproduce it.

@Tofandel

This comment has been minimized.

@Tofandel
Copy link
Contributor

Tofandel commented Jan 14, 2022

Why was my comment hidden?
Anyways found out that you need to explicitely set :permanent="true" which is a redundant prop but anyways, this is what's needed now

Edit: Ah, my bad the fix wasn't released yet as I wrote, hence my comment

@L2Ernestoo
Copy link

L2Ernestoo commented Jan 25, 2022

correctly, now if miniVariant
How did you make it work? I was trying with what you put but still the same.

image

and I already updated to version 2.6.3 and it's still the same

@theRenard
Copy link

theRenard commented Jan 27, 2022

I still have the issue, or maybe the doc needs an update because what was working in 2.5.10 is not working anymore with the same configuration

    expand-on-hover
    disable-resize-watcher
    hide-overlay
    permanent
    mini-variant-width="80px"```

@Tofandel
Copy link
Contributor

What are you expecting vs what are you getting? I see no difference with the props you gave in 2.6.1 and 2.6.3, the bug in 2.6.2 seems to have been fixed in 2.6.3

@theRenard
Copy link

Expecting

image

Getting

image (1)

We were experiencing this issue in production where CI wasn't honoring the yarn.lock file and the Vuetify version was the last available (2.6.3). We didn't have this issue on our local env where we had v.2.5.10 so we fixed the issue bonding the package version to 2.5.10. We didn't had time to investigate more on this issue but if needed I can help to setup a codepen to reproduce it.

@KaelWD
Copy link
Member

KaelWD commented Jan 28, 2022

Please follow #14585

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VNavigationDrawer VNavigationDrawer T: bug Functionality that does not work as intended/expected T: regression Something that used to work but we broke
Projects
None yet
Development

No branches or pull requests

8 participants