Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report][3.1.2] can't apply inline styles to v-card #15947

Closed
jd-solanki opened this issue Oct 21, 2022 · 2 comments
Closed

[Bug Report][3.1.2] can't apply inline styles to v-card #15947

jd-solanki opened this issue Oct 21, 2022 · 2 comments
Labels
C: VCard VCard upstream Problem with a third party library that we may have to work around

Comments

@jd-solanki
Copy link
Contributor

jd-solanki commented Oct 21, 2022

Environment

Vuetify Version: 3.0.0-beta.14
Vue Version: 3.2.41
Browsers: Chrome 106.0.0.0
OS: Mac OS 10.15.7

Steps to reproduce

  1. Open the reproduction line
  2. Inspect the v-card styles

Expected Behavior

Card shoule have min-height 100%

Actual Behavior

style attribute is empty

Reproduction Link

https://play.vuetifyjs.com/#...

@KaelWD
Copy link
Member

KaelWD commented Oct 21, 2022

Vue bug.

vnode.props.style has

{
  height: undefined,
  maxHeight: undefined,
  maxWidth: undefined,
  minHeight: undefined,
  minWidth: undefined,
  width: undefined,
  min-height: "100%"
 }

patchStyle() is calling

style.minHeight = ''
style.minHeight = '100%'

then style.minHeight = '' again because of https://github.com/vuejs/core/blob/85af1398637ee91c6ebabb73bf42250320311e19/packages/runtime-dom/src/modules/style.ts#L13-L19

@KaelWD KaelWD added the upstream Problem with a third party library that we may have to work around label Oct 21, 2022
@johnleider johnleider added C: VCard VCard and removed S: triage labels Jan 22, 2023
@johnleider johnleider changed the title [Bug Report][3.0.0-beta.14] can't apply inline styles to v-card [Bug Report][3.1.2] can't apply inline styles to v-card Jan 22, 2023
@KaelWD
Copy link
Member

KaelWD commented May 27, 2023

Fixed by vuejs/core#7425

@KaelWD KaelWD closed this as completed May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VCard VCard upstream Problem with a third party library that we may have to work around
Projects
None yet
Development

No branches or pull requests

3 participants