Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(locale): update arabic translations #16290

Merged
merged 3 commits into from
Dec 21, 2022
Merged

fix(locale): update arabic translations #16290

merged 3 commits into from
Dec 21, 2022

Conversation

Mosaab-Emam
Copy link
Contributor

Description

I clarified, fixed, and completed translating all texts in ar.ts.

Fixes #16185

Motivation and Context

The Arabic locale file is not complete. Some texts are not translated, others have unclear translations.
Fixes #16185 opened by myself.

How Has This Been Tested?

Visually.

Markup:

None.

// Paste your FULL Playground.vue here

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@KaelWD
Copy link
Member

KaelWD commented Dec 20, 2022

@gimyboya @melbahja review this please

Copy link
Contributor

@khawarizmus khawarizmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR @Mosaab-Emam. there was a lot of lousy and long translations in this file.

packages/vuetify/src/locale/ar.ts Show resolved Hide resolved
packages/vuetify/src/locale/ar.ts Outdated Show resolved Hide resolved
packages/vuetify/src/locale/ar.ts Outdated Show resolved Hide resolved
packages/vuetify/src/locale/ar.ts Outdated Show resolved Hide resolved
@Mosaab-Emam
Copy link
Contributor Author

You are welcome @gimyboya, always happy to help.

I pushed a commit with a couple of your suggestions.

@khawarizmus
Copy link
Contributor

@KaelWD @Mosaab-Emam LGTM.

@KaelWD
Copy link
Member

KaelWD commented Dec 21, 2022

Thanks @gimyboya

@KaelWD KaelWD added this to the v2.6.x milestone Dec 21, 2022
@KaelWD KaelWD changed the title fix: perfect arabic translation fix(locale): update arabic translations Dec 21, 2022
@KaelWD KaelWD merged commit 9169a06 into vuetifyjs:master Dec 21, 2022
@Mosaab-Emam Mosaab-Emam deleted the Fix/#16185-perfect-arabic-translation branch December 21, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Perfect arabic locale
3 participants