Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] [VFileInput] Types: Add accept attribute (Volar gives error now) #17069

Open
0x00A1FA opened this issue Apr 3, 2023 · 3 comments
Assignees
Labels
framework Issues and Feature Requests that have needs framework-wide. has workaround T: bug Functionality that does not work as intended/expected typescript
Milestone

Comments

@0x00A1FA
Copy link

0x00A1FA commented Apr 3, 2023

Problem to solve

Volar would not give the error below (which basically says that accept is not defined on the VFileInput type):

Argument of type '{ $children: any; modelValue: File[]; accept: string; label: string; prependIcon: string; 'prepend-icon': string; rules: ValidationRule[] | undefined; }' is not assignable to parameter of type 'Partial<{ reverse: boolean; error: boolean; active: boolean; direction: "horizontal" | "vertical"; disabled: boolean; multiple: boolean; readonly: boolean; counter: boolean; messages: string | string[]; ... 17 more ...; showSize: boolean | ... 1 more ... | 1024; }> & Omit<...>'.
  Object literal may only specify known properties, and 'accept' does not exist in type 'Partial<{ reverse: boolean; error: boolean; active: boolean; direction: "horizontal" | "vertical"; disabled: boolean; multiple: boolean; readonly: boolean; counter: boolean; messages: string | string[]; ... 17 more ...; showSize: boolean | ... 1 more ... | 1024; }> & Omit<...>'.ts(2345)

Proposed solution

Add the accept prop in VFileInput.

P.S.: Kind request: Briefly comment on your experience regarding the different Volar changes over time that affected Vuetify, please!

yuwu9145 added a commit that referenced this issue Apr 4, 2023
@yuwu9145 yuwu9145 self-assigned this Apr 4, 2023
@KaelWD KaelWD added T: bug Functionality that does not work as intended/expected framework Issues and Feature Requests that have needs framework-wide. and removed C: VFileInput labels Apr 4, 2023
@KaelWD KaelWD self-assigned this Apr 4, 2023
@KaelWD KaelWD added this to the v3.x.x milestone Apr 4, 2023
@github-actions github-actions bot removed the S: triage label Apr 4, 2023
@KaelWD
Copy link
Member

KaelWD commented Apr 4, 2023

@johnleider

This comment was marked as outdated.

@johnleider
Copy link
Member

Is this still an issue? Volar is deprecated.

@yuwu9145 yuwu9145 removed their assignment Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework Issues and Feature Requests that have needs framework-wide. has workaround T: bug Functionality that does not work as intended/expected typescript
Projects
None yet
4 participants