Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report][3.3.X][Types] Event-only components and ComponentCustomProps augmentation doesn't work properly since 3.3.0 #17545

Closed
ferferga opened this issue Jun 6, 2023 · 2 comments
Labels
T: bug Functionality that does not work as intended/expected typescript upstream Problem with a third party library that we may have to work around

Comments

@ferferga
Copy link
Contributor

ferferga commented Jun 6, 2023

Environment

Vuetify Version: 3.3.2
Last working version: 3.2.5
Vue Version: 3.3.4
Browsers: Edge 114.0.1823.37
OS: Windows 10

Steps to reproduce

  1. Clone the repro repository or start a Codespace from master
  2. Run npm remove vuetify && npm i vuetify@3.2.5 && npm ci && npm run typecheck to install 3.2.5 (the latest working version) and run type-checking against it
  3. You will only receive 6 type errors (related to fix(types): components inherit HTMLAttributes interface #17082, but irrelevant for this issue)
  4. Run npm remove vuetify && npm i vuetify && npm ci && npm run typecheck to reinstall and run type-checking against 3.3.2
  5. You will receive 12 type errors. Those new 6 type errors are the ones this issue is reporting, you can ignore the ones received at step 3.

Expected Behavior

  • v-btn, v-app-bar-nav-icon and v-avatar doesn't report any type error when being used only with the @click prop. If you add any of the other valid props, the issue is gone
  • Module augmentation at frontend/src/types/global/attributes.d.ts of ComponentCustomProps work for the data-swiper-parallax type error.

Actual Behavior

Reproduction Link

https://github.com/jellyfin/jellyfin-vue

Other comments

I'm attaching the whole repo as a reproduction since I believe it's going to simplify debugging in this case by having the whole TypeScript and bundler configuration in place.

@ferferga ferferga changed the title [Bug Report][3.3.2][Types] Event-only components and ComponentCustomProps augmentation doesn't work properly [Bug Report][3.3.X][Types] Event-only components and ComponentCustomProps augmentation doesn't work properly since 3.3.0 Jun 6, 2023
@KaelWD
Copy link
Member

KaelWD commented Jun 6, 2023

vuejs/core#8376

@ferferga
Copy link
Contributor Author

ferferga commented Jun 6, 2023

@KaelWD Great thanks! I believe then that the @click handler is also related to #16190?
In that case, feel free to mark it as duplicated from that one and closing this.

Sorry for all the hassle.

@KaelWD KaelWD added T: bug Functionality that does not work as intended/expected upstream Problem with a third party library that we may have to work around typescript labels Jun 13, 2023
@KaelWD KaelWD closed this as completed Nov 13, 2023
@KaelWD KaelWD added this to the v3.4.0 (Blackguard) milestone Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: bug Functionality that does not work as intended/expected typescript upstream Problem with a third party library that we may have to work around
Projects
None yet
Development

No branches or pull requests

2 participants